Your political predictions, to be fair, have been pretty poor--which is hardly unexpected, because your predictions are always that Democrats are doomed. You foresaw doom for Obama (both times), you certainly never saw supermajorities for the Democrats in both Houses in 2008, etc. When your predictions are really just attempts to aggravate "the libs" on this forum, you wouldn't expect a great hit rate, right?
I don't think this impeachment had much effect either way--the nation is pretty entrenched in their views, one way or the other. There are barely any "true independents" that are swayable--most independents are just people who like the sound of the label but always vote either Republican or Democrat. How you see the impeachment pretty much boils down to your priors going into it.
The Presidential election will mostly revolve around which party energizes their base the most. Democrats were clearly the more energized party in 2018, and they once again lead the generic ballot by a significant margin (6-7 points) but there's a long way to the election and a lot of Trump voters won't be all that "energized" until Trump himself is on the ballot.